Skip to content

W25/trinity/ setup color theme + typography#64

Merged
trinity-y merged 3 commits intomainfrom
W25/trinity/set-up-color-theme
Feb 22, 2025
Merged

W25/trinity/ setup color theme + typography#64
trinity-y merged 3 commits intomainfrom
W25/trinity/set-up-color-theme

Conversation

@trinity-y
Copy link
Contributor

clean branch for colour theme / typography

Notion ticket link

Set Up Color Theme

Implementation description

  • created theme directory
  • access colours like blue.700, or, if there's no shade do white.default
  • look at CreatePasswordPage.tsx for example
  • text styles are used just like before

Steps to test

  1. you can open create password page to see that the colours work

What should reviewers focus on?

  • CreatePasswordPage for example
  • frontend/src/theme/colors

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Contributor

@shencynthia shencynthia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥🔥🔥🔥

Thanks for doing the text as well :)

Left one comment, please address it then merge.

Copy link
Contributor

@shencynthia shencynthia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the file after design confirmed it is up to date. Note: h3 and subheadding are identical, and design confirmed that this is intended.

@trinity-y trinity-y added this pull request to the merge queue Feb 22, 2025
Merged via the queue into main with commit 80e7e46 Feb 22, 2025
1 check passed
@trinity-y trinity-y deleted the W25/trinity/set-up-color-theme branch April 8, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants