W25/trinity/ setup color theme + typography#64
Merged
Conversation
shencynthia
reviewed
Feb 21, 2025
shencynthia
approved these changes
Feb 21, 2025
Contributor
shencynthia
left a comment
There was a problem hiding this comment.
LGTM 🔥🔥🔥🔥🔥🔥
Thanks for doing the text as well :)
Left one comment, please address it then merge.
shencynthia
reviewed
Feb 21, 2025
Contributor
shencynthia
left a comment
There was a problem hiding this comment.
Updated the file after design confirmed it is up to date. Note: h3 and subheadding are identical, and design confirmed that this is intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean branch for colour theme / typography
Notion ticket link
Set Up Color Theme
Implementation description
blue.700, or, if there's no shade dowhite.defaultCreatePasswordPage.tsxfor exampleSteps to test
What should reviewers focus on?
Checklist